Variable name typos #3231
Closed
Variable name typos #3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@timkelty noted that renaming arguments of non-private methods is actually a breaking change for PHP 8.0+, due to named arguments. So, maybe this needs to target 5.0? |
|
Added todo into the code for next major release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$currentPlanhad an extratat the end in a couple of instances!This is an inconsequential patch—in both cases, the variable wasn't actually used in-scope… and to my knowledge, interfaces aren't required to have the same argument names (just the types).See below! 😬
🌱